On 11.09.2024 at 15:51, Derick Rethans wrote:
> On Sun, 8 Sep 2024, Christoph M. Becker wrote:
>
>> On 08.09.2024 at 16:58, Derick Rethans wrote:
>>
>
> Ok, but I still don't see why you need an RFC for this? :-)

Oh, I don't need an RFC for this.  Actually, you can read my question as
"does this *really* need an RFC, or can we do without?"

> I know Shivam (https://github.com/php/web-downloads) has also been
> working on doing automatic pulls of PECL builds onto the "downloads"
> server.
>
> The idea was to trigger a GitHub action to call to this API to then
> download file file. Ideally the downloads server *pulls* files, as
> uploading *to* it can't work through GHA as we require 2FA through a
> jump host.

I see.

> We'll have to have multiple Git repositories, and perhaps subdomain
> names to make this all work.
>
> The downloads.php.net site currently doesn't have any code yet, as I am
> waiting for this 404 ErrorHandler to be included in it:
>
>       <?php
>       if (preg_match('/Win32-vc/', $_SERVER['REQUEST_URI'])) {
>               $fixed = str_replace( 'Win32-vc', 'Win32-VC', 
> $_SERVER['REQUEST_URI'] );
>               header("Location: $fixed", true, 301);
>               exit();
>       }
>
>       header('Location: /', true, 404);
>
> Ideally, instead of having downloads.php.net/~windows, we have
> downloads.php.net/windows which is a Git repository for the series
> files, but it is probably better if it's all in that same web-downloads
> repository.

Oh, there might be slight misunderstanding.  By "series files" I only
refer to what is in
<https://downloads.php.net/~windows/php-sdk/deps/series/>; nothing else.

While the upload/download issue might be solved one way or the other,
having a Git repository for the series files might solve a couple of
issues.  I've set up <https://github.com/cmb69/php-windeps-series> as a
demonstration of what I have in mind.  For instance, it is hard to keep
an overview of which packages are in which series; packages.csv helps a
bit (and GH displays this nicely[1]).  And then I made PR #1, which
shows a x64/x86 mismatch[2] (actually multiple, but ignore the trailing
-1 lines mismatches).  Finally, I made PR #2, which uses a locally run
script to push staging to stable.  Many more checks and automations can
be done in the future; but you already get the gist.

[1] <https://github.com/cmb69/php-windeps-series/blob/main/packages.csv>
[2]
<https://github.com/cmb69/php-windeps-series/actions/runs/10815285786/job/30003806974?pr=1#step:3:17>

Christoph

Reply via email to