On 31.08.2024 at 19:35, Derick Rethans wrote: > Shouldn't we have bumped the API number for this? Better safe than sorry.
That ABI break was accidentially committed. There was some discussion whether to stick with the break and bump API numbers, or to revert, and there was consensus that in this case the latter makes more sense (after all, just a single release was affected, and only relevant for extensions which actually use the streams layer). > And I'm wondering why we have no tests for ABI breaks here? I'm sure that I > have seen a report (from Remi?) that highlighted these breakages when I was > still involved in the mongodb extension. There was the idea to do some verifcation, but maybe it's enough to add something to the PR-labeler which just labels any PR which modifies a public header. Christoph
