Stupid question maybe, but are we voting on the RFC or on the patch? If the patch does not match what.the RFC proposes, then the patch has a problem. That should IMO though not affect voting on an RFC.
Or am I.missimg something? Cheers Andreas On 7 August 2024 16:27:56 CEST, Derick Rethans <der...@php.net> wrote: >On 7 August 2024 14:30:24 BST, Theodore Brown <theodor...@outlook.com> wrote: >>On Tue, July 30, 2024 at 03:49 G. P. Banyard wrote: >> >>> Hello Internals, >>> >>> I have just opened the vote for the "Transform exit() from a language >>> construct into a standard function" RFC: >>> https://wiki.php.net/rfc/exit-as-function >>> >>> The vote will last for two weeks until the 13th of August 2024. >> >>I really appreciate RFCs like this which not only make the language more >>consistent for userland developers, but also simplify PHP's internal >>implementation, paving the way for future optimizations and new functionality. >> >>In my experience, extension developers nearly always have to make some >>changes to support each new PHP version, so I'm not sure why that would be a >>reason to prevent improving the language. > >This is misrepresenting my concern. > >I understand that new versions require changes. > >One of my issues is, is that so far I could not find a way to replicate >existing functionality with this patch applied. > >The RFC does not mention a BC break, nor does it have an entry for >UPGRADING.INTERNALS either. > >cheers >Derick
