On Sat, Jul 6, 2024 at 1:09 AM chopins xiao <chopins.x...@gmail.com> wrote:
> The reason I'm not so polite is because I'm so angry. Firstly, the > Deprecate functions with overloaded signatures RFC's approach to FFI > recommendations is unfounded, and secondly, the PR commit( > https://github.com/php/php-src/commit/4acf0084dcd63ec369a610ec966db33f322694c8) > has not been voted on by the RFC, and the implementation is very simple and > crude, and does not solve the problem that FFI's API is not so elegant （At > the very least, there are shortcomings such as complicated API calls, mixed > use of multiple types of functions, and reduced performance）. > There are so many masters,I don't understand why it was merged. The commit > implementation was not voted on, and it is possible to withdraw it first. > > Very unfortunate. Might have a solid technical case, but you: 1. Called someone who contributed to the project with actual code stupid because they didn't do what you'd prefer. 2. Called the implementation they provided "simple and crude". 3. Asked about this on GitHub and were told it was voted on, but are bringing this anyway: https://github.com/php/php-src/issues/14608 4. Opened this ML thread with a request/demand to revert the commit simply because you want to talk about your proposal. 5. Did all of the above without any indication that you could provide a non-"simple and crude" implementation since you are apparently better at it than everyone else who contributes. Regardless of the technical merits, you're not going to win many discussions like that. Jordan
