On Wed, Apr 24, 2024 at 2:55 PM Lynn <kja...@gmail.com> wrote: > > > On Tue, Apr 23, 2024 at 3:30 PM Benjamin Außenhofer <kont...@beberlei.de> > wrote: > >> Hi internals, >> >> My PR for #[\Deprecated] attribute was in hibernation for a long while >> now and after some off-list discussion a few weeks ago I have decided to >> revisit it and asked Tim to help me out with the work. >> >> Tim has cleaned up the PR quite a bit and also worked in additional >> features such as #[Deprecated] support in stub generation. >> >> While there are still some small todos, at this point we want to restart >> the discussion about the RFC for inclusion in 8.4: >> >> RFC: https://wiki.php.net/rfc/deprecated_attribute >> PR: https://github.com/php/php-src/pull/11293 >> Old discussion: https://externals.io/message/112554#112554 >> >> Let me know about your questions and feedback. >> >> greetings >> Benjamin >> > > JetBrains was mentioned in the previous discussion but not sure if this > was considered in the RFC: > https://github.com/JetBrains/phpstorm-attributes/blob/master/src/Deprecated.php > >
Yes we considered it, but this is one implementation of a vendor, it might be conflicting with requirements of other projects and vendors. For the implementation and the engine itself this information is just "weight" that is carried around, so we decided not to add them, because its harder to decide on what to include than recommending tools to add their own supplemental attributes.
