On Tue, Mar 5, 2024, at 7:25 AM, youkidearitai wrote:
> 2024年3月5日(火) 5:52 Niels Dossche <dossche.ni...@gmail.com>:
>>
>> Hi Yuya
>>
>> This sounds useful.
>>
>> I do have a question about the function signature:
>> function grapheme_str_split(string $string, int $length = 1): array {}
>>
>> This always returns an array.
>> However, looking at your PR it seems you return NULL on failure, but the
>> return type in the signature isn't nullable.
>> Also, from a quick look, it seems other functions return false instead of
>> null on failure. So perhaps the return type should be array|false.
>>
>> What do you think? :)
>>
>> Kind regards
>> Niels
>>
>> On 03/03/2024 00:21, youkidearitai wrote:
>> > Hi, Internals
>> >
>> > I noticed PHP does not have grapheme cluster for str_split function.,
>> > Until now, you had to use the PCRE function's \X.
>> >
>> > Therefore, I try create `grapheme_str_split` function.
>> > https://github.com/php/php-src/pull/13580
>> > It is possible to convert array per emoji and variation selectors using
>> > ICU.
>> >
>> > If it's fine, I'll create an RFC.
>> >
>> > Regards
>> > Yuya
>> >
>
> Hi, Niels
>
> Thank you for your comment.
> Indeed, returns false is make sense.
>
> Therefore, I changed to returns false when invalid UTF-8 strings.
>
> Regards
> Yuya
Many legacy functions return false on error, but that is widely regarded as bad
design. Please do not continue bad design.
Right now, the best "standard" error handling mechanism available is
exceptions. false (or null) can very easily lead to incorrectly using that
value as though it were valid, when it's not, which will sometimes cause a
fatal error and sometimes cause a security leak.
If the input value cannot be logically processed, that's an exception. (Or
Error, perhaps.)
--Larry Garfield
