Hi
On 2/26/24 12:26, Hans Henrik Bergan wrote:
Made a RFC draft: https://wiki.php.net/rfc/sleep_function_float_support
First time, so I'm not surprised if there are some mistakes there.
Thank you for the RFC. I have some suggestions to improve the
readibility within the Wiki, as Markdown doesn't really render well
there. The documentation is here: https://wiki.php.net/wiki/syntax
- Instead of using backticks, use `<php>sleep()</php>` for inline and
`<PHP>…</PHP>` for multi-line snippets. This comes with syntax
highlighting and documentation links.
- It would help readability if you'd use additional headlines for each
of the three sub-proposals within the Proposal section.
Regarding the contents:
For (2) it would help if you'd explain what it means for sleep() to be
interrupted and how this can happen. I believe this is signal-handling
related, but writing it out explicitly for the folks that didn't yet
encounter it would probably make sense.
For the "Unaffected PHP Functionality" you could just spell out that
anything that is not the sleep() function will be unaffected and more
specifically any code that does not currently emit a deprecation is most
likely unaffected.
Regarding the voting options, I agree with Ayesh that 6 votes is too
many. I'd even say it's 5 votes too many, instead of 3 votes to many.
I'd just put a single "Do all of this in the next minor" vote there. All
of the suggested improvements make sense to me and the breaking changes
are mostly theoretical. I don't think I've ever seen anything using the
return value of sleep(). Furthermore it doesn't make sense to accept
(1), but not accept (3), as that would result in somewhat inconsistent
behavior as you cannot $sleep = somefloat; while (($sleep =
sleep($sleep)); to sleep for that exact somefloat value in the face of
interrupts. Simple RFC, simple voting choice.
Lastly, I see that the RFC still is in Draft stage. Don't forgot to open
up a dedicated explicit discussion thread once you move it into the
"Discussion" phase.
Best regards
Tim Düsterhus
