Derick Rethans wrote:
On Tue, 14 Sep 2004, Rasmus Lerdorf wrote:


That should have been a #ifndef SKIP_PATH_CHECKS there.  And it is there
to get rid of a non-critical ftell().


Attached is the patch with this corrected, and corrected white space.


And yes, there is no doubt that this patch can critically alter the way
PHP works and has the potential to break all sorts of stuff.  Anything
that relies on PHP knowing the full path will break.  I had to fix both
xdebug and APC, for example.  At the same time, enough people have asked
me about it that it probably should be more accessible.


I agree, there are a lot of people who might benefit from it (and do
already!) and thus the reason for me to put it into something usable for
everybody so that 1) rasmus doesn't have to maintain the patch anymore
and 2) users don't have to keep updating their PHP whenever they upgrade
PHP.

Derick

Both points make sense. Just name the configure option well and put big warnings there
that when the option is switched on this _may_ lead to crashing applications.

Andrey

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Reply via email to