Hi
On 9/15/23 17:50, Ben Ramsey wrote:
Additionally, despite the use of a Git submodule complicating things for
"everyone else," it provides a clear dependency and development
boundary, avoiding situations where the php-src version of IR drifts
from the upstream version. I think we can adjust tooling and messaging
to help folks know how to use the submodule. :-)
Do not want: If the submodule repository goes away for whatever reason,
the dependency will no longer be available. IR is currently sitting in
Dmitry's personal GitHub account and it would not be the first time that
a GitHub account is suspended for good or less good reasons [1].
Bundle IR in some dedicated directory with php-src. Then updating it is
as easy as "throw away the directory and copy over the new files". We
could even automate that using GitHub actions to sync in the changes
every night or so.
Dmitry also said that he gave 'git subtree' a try. I don't know that
command myself, but it looks exactly like what is required here. I would
be interested in hearing why it didn't work well.
Best regards
Tim Düsterhus
[1] Such as sanctions, see:
https://techcrunch.com/2019/07/29/github-ban-sanctioned-countries/
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php
