> I'm not opposed to these, but would this be a good time to also add an > interface for attributable reflection objects, so that we can type against > that? These methods would all then go on that interface.
I was going for a tiered approach. Once these methods were in, I would propose adding an Attributable or ReflectorWithAttributes interface, as well as a separate proposal to have ReflectionAttribute aware of the Attributable/ReflectionWithAttributes that it came from. > What's the difference between this and what was proposed in > https://externals.io/message/120799 ? My proposal adds 3 methods, not just one, and was a followup to something from a while ago. > I don't get why this wouldn't require an RFC. It's adding missing methods that should realistically be there. It breaks nothing, nor does it introduce entirely brand new things. It's the same as getParameter()/hasParameter() <https://github.com/php/php-src/pull/10431> and hasPrototype() <https://github.com/php/php-src/pull/8487>. I couldn't tell you exactly why, just that the core contributors said so. > FY I started working on the implementation., hopefully it will bring more > arguments in favor of that RFC which I’m willing to submit asap as well. Is it just the hasAttribute() method you're working on? I'm happy to help out if you need/want it. I was moments away from opening a PR. --- Best Regards, *Ollie Read*
