On 2023/02/01 13:13, Max Kellermann <max+...@blarg.de> wrote: > Voting starts now, please vote on my RFC: > https://wiki.php.net/rfc/include_cleanup
Hi, voting of https://wiki.php.net/rfc/include_cleanup has ended today at 15 UTC. The majority of voters (52%) voted "Yes" on the primary vote - "Should #include directives be cleaned up?" - but the required supermajority for a primary vote was not met. Therefore, the primary vote is declined. On the secondary vote "Is it allowed to document an #include line with a code comment?", 90% of all voters do not want to allow code comments on #include lines. To fix the PHP code base according to this decision, please consider merging https://github.com/php/php-src/pull/10472 The secondary vote "Is it allowed to forward-declare structs/unions/typedefs?" was clearly rejected as well; 87.5% of all voters thought forward declarations should not be allowed. There are numerous unnecessary forward declarations; several of these are removed by https://github.com/php/php-src/pull/10494 - please consider merging this PR for compliance with this decision. Interestingly, of all things, the most intrusive vote ("Is it allowed to split a large header to reduce dependencies?") got accepted by a supermajority. I'll assemble a PR with just the header splitting commits and submit it for merging. >From my minimal #include cleanup PR (https://github.com/php/php-src/pull/10410), I have removed all include comments. The RFC failed to meet the supermajority, but I'm not sure if that means that #include cleanups are now (or still?) forbidden. Having a majority, but no supermajority sounds like it's inconclusive, but I don't know what that means and how to proceed. Max -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
