On 2023/01/18 18:51, Kamil Tekiela <tekiela...@gmail.com> wrote: > - I am against forward struct declarations. I think they decrease code > readability and should be avoided.
btw. if this opinion is shared by the majority of voters, I'll send a PR to remove all existing forward declarations from PHP. There are many, for example zend_object_handlers in Zend/zend_types.h added by https://github.com/php/php-src/commit/c80e82230b5 Though one very interesting commit to introduce a forward declaration is https://github.com/php/php-src/commit/f4cfaf36e23ca (forward-declared zend_ast) > - I am against putting comments on #includes. Same here - there are currently 47 #includes with comments (none of which were written by me, some dating back 24 years ago). I'll take care of removing them all, if it turns out that the majority of voters doesn't like them. Max -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
