Hi
On 1/16/23 17:36, Tim Düsterhus wrote:
From my experience contributing to another C project (HAProxy),
cleaning up the the includes can have a measurable impact on build
times. See this commit for example:
Sorry for the duplicate mail, but it just came to my mind checking the
CI build logs from before and after the revert:
-------------
Before (x64 Release ZTS)
https://github.com/php/php-src/actions/runs/3924250312/jobs/6708385711
After:
https://github.com/php/php-src/actions/runs/3929927482/jobs/6719316931
9:26 minutes -> 9:52 minutes
Before (x64 Debug NTS):
https://github.com/php/php-src/actions/runs/3924250312/jobs/6708385677
After:
https://github.com/php/php-src/actions/runs/3929927482/jobs/6719316800
4:14 minutes -> 5:11 minutes
-------------
So with the changes that already happened, Max managed to shave off 30
seconds (5%) for the x64 Release ZTS build and 1 minute (19%) for the
x64 Debug NTS build. This difference would likely become even larger, as
to my understanding the cleanup wasn't complete yet.
Best regards
Tim Düsterhus
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php
