On Tue, Nov 22, 2022, at 12:08 PM, Tim Düsterhus wrote: > Hi > > On 11/14/22 21:02, Claude Pache wrote: >> To clarify my position: >> >> * The set visibility must be either more restrictive or of the same >> restriction level than the get visibility. >> >> * When the set visibility is absent, it is inferred as following: >> * If `readonly` is present, the set visibility is `private` (as of >> today); >> * otherwise, the set visibility is the same as the get visibility >> (again, as of today). >> >> * We don’t judge whether it is reasonable to write `protected protected(set) >> string $foo;` when you could just write `protected string $foo` for the same >> effect. Similarly, we don’t judge whether it is reasonable to write `public >> function()` when you could just write `function()` for the same effect. We >> leave it to coding styles and linters to decide whether the short form or >> the long form is preferred. >> > > I agree with that. > > -------------- > > As I'm sending an email anyway: Larry, will there be a a new separate > discussion thread, once all the problems are resolved and once it's > clear what you propose? I just noticed the "Abbreviated Form" section in > the RFC > (https://wiki.php.net/rfc/asymmetric-visibility#abbreviated_form) which > I disagree with, which apparently was added in October, but I remember > an email letting readers know of the updated RFC. I didn't follow the > evolution of the RFC too closely, though, because I believed that it > still was in a somewhat early stage and because discussion is already > split into way-to-many threads and also the poll. > > Best regards > Tim Düsterhus
Yes, once we make a decision on this point, I'll respond in this thread. The abbreviated form was part of the discussion earlier, and the syntax we settled on supported it, so it made sense to include. I try to highlight on the list any time notable changes are made, even if I don't always have a detailed changelog. Whether it makes sense to use the same thread or a new thread varies, and I'm absolutely certain others will make a different judgement call on that than I do. I'm not aware of any standard convention around that, so until one exists I'll just continue making vaguely educated guesses on that front. Given the timing, Ilija says he'd prefer to not call the vote until after the new year/holidays. Feedback still welcome at this point but aside from edge cases like this thread's, I think we're pretty well set on the basic features. Baring any major change of direction expect the vote to be called in early January, probably. Time permitting we're going to also start work on property hooks/accessors, which is the intended follow-on to this RFC. --Larry Garfield -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
