Hi Nicolas, On Thu, 8 Sept 2022 at 18:06, Nicolas Grekas <nicolas.grekas+...@gmail.com> wrote: > > There needs to be serious justification for it.
I think this is covered by the RFC. The current behaviour where people have to setup a custom error handler, and then restore the previous error handler, is pretty 'ungood'. The proposed replacement behaviour, where people can actually find out the problem that happened is better. > About 2., unserialize() accepts a second argument to give it options. Did > you consider adding a 'throw_on_error' option to opt-in into the behavior > you're looking for? A new option might be a good idea, but unserialize should have sensible defaults, and the current behaviour is really not that sensible. So, imo, an opt-out would be a better choice. It would allow anyone who cares enough to keep backwards compatibility when they upgrade to the next version of PHP by adding that to the options array, but everyone who is unaware of the option gets the more sensible behaviour by default. cheers Dan Ack -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
