At 10:29 AM 8/20/2004 +0800, Alan Knowles wrote:
Andi Gutmans wrote:
I actually don't think it's the right approach. ext/overload has always been experimental and it doesn't make sense to start putting such a hack into the engine.
Normally that would make sense, but the change is realitively minor, and it would reduce the necessity to upgrade libraries for alot of users.
You can easily change the code to use conditional includes and therefore, your PHP 4 version won't be compiled under PHP 5.
I guess so this may end up being the only option, other than kludgy evals, it's just a bit of a shame to have to include a file for just for 5 lines of code.
Do you know how many PEAR classes are actually affected by this?
2 PEAR classes XML_FastCreate and DB_DataObject.
Two are very few. I don't think eval's with heredocs would be that kludgy. At least not for such a small amount of classes.
Andi
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
