Hey Tyson, <http://ocramius.github.com/>
On Tue, Jun 15, 2021 at 4:01 PM tyson andre <tysonandre...@hotmail.com> wrote: > Hi internals, > > Voting has started on the ImmutableIterable RFC > https://wiki.php.net/rfc/cachediterable > > Previous discussion can be found in https://externals.io/message/114834 > > Recent changes: > - The name was renamed to `ImmutableIterable` to indicate that it cannot > be changed after being constructed. > It was brought up in previous discussions that the previous name of > `CachedIterable` could easily be assumed to have functionality similar to > on-demand iterators/iterables such as https://php.net/cachingiterator > (Additionally, immutability is rare among spl data structures) > - `__set_state` was added > I see the RFC as valuable but: * `__serialize` and `__unserialize` are out of scope: this depends on the contents of it, and there's no point in implementing them * `__set_state` should also not be implemented: `var_export()` like any other object and it should be fine * `jsonSerialize` also depends on the contents, and shouldn't be exposed All of this is not part of what should be in a reusable iterator. Greets, Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/
