On 10.05.2021 10:49, Matīss Treinis wrote:
> Another point to be made here, as far as my interpretation of PSR-12, the
> curly braces occupy two lines for methods with multiline arguments. So for
> whoever follows PSR-12, it's more like this, with brackets just dangling
> there across 2 lines.
>
> [...]
> class Foo {
> public function __construct(
> private Bar $bar,
> private Baz $baz
> ) {
> }
> }
or some would prefer:
class Foo {
public function __construct(
private Bar $bar,
private Baz $baz
) {
// empty
}
}
The question to the proposal. Will this new syntax apply to:
1. all methods
2. all constructors
3. only to constructors with property promotion?
I think 3 makes most sense here and is less contentious. So, just be
sure to specify this in the RFC.
--
Aleksander Machniak
Kolab Groupware Developer [https://kolab.org]
Roundcube Webmail Developer [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php
