Hi internals, I have updated the GitHub PR and wiki RFC to also include an implementation of fdatasync.
On another note, I note my PR builds are failing on MACOS_DEBUG_NTS with a test in ext/zend_test/tests/observer_error_05.phpt- this does not appear to be related to my changes and I'm wondering if anyone can shed any light on this? I'm seeing it on some other open PRs too so I'm guessing it's a known issue? Cheers. David Gebler davidgeb...@gmail.com On Sat, Jan 30, 2021 at 6:34 PM David Gebler <davidgeb...@gmail.com> wrote: > Updated the PR https://github.com/php/php-src/pull/6650 following comment > from Nikita, added basic tests, would appreciate further review from > contributors, have updated the RFC https://wiki.php.net/rfc/fsync_function to > under discussion, cheers. > > David Gebler > davidgeb...@gmail.com > > > On Sat, Jan 30, 2021 at 1:58 AM David Gebler <davidgeb...@gmail.com> > wrote: > >> Hi internals, >> Some time back I asked for commentary on a proposal to add fsync() to >> PHP, I have now submitted a draft RFC >> https://wiki.php.net/rfc/fsync_function alongside an in-progress proof >> of concept PR (current status: can compile locally and run but the branch >> needs more work to bring it up to standard, as well as tests and >> documentation) which I would like to open up for review and discussion. >> >> Thanks. >> >> David Gebler >> davidgeb...@gmail.com >> >>
