On Thu, 26 Nov 2020 at 02:42, Sara Golemon <poll...@php.net> wrote: > Maybe just a wee bit late to ask this question, but shouldn't we have long > since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ? > > Was that deliberate since (unlike with 4->5 and 5->7) the engine's API > surface area hasn't skewed so bad? > > I ask because ZEND_VERSION did get updated to the 4.x.x series. > > -Sara >
Wasn't there discussion about dropping the ZEND_ENGINE_* constant? As the Zend API changes between minor versions it is debatable how better it is to check for that constant instead of a version number. Best, George P. Banyard
