thanks Nikita, we didn’t notice until we went to build the beta and RC RPMs in prep for release.
We looked over the breaking changes list but I guess we didn’t read far enough down the entire changes list. Dropping DSO is not a bad thing since there are so many other better ways to serve PHP. > On Nov 18, 2020, at 4:04 PM, Nikita Popov <nikita....@gmail.com> wrote: > > On Wed, Nov 18, 2020 at 10:54 PM Dan Ackroyd <dan...@basereality.com > <mailto:dan...@basereality.com>> wrote: > On Tue, 10 Nov 2020 at 20:22, Dan Muey <d...@cpanel.net > <mailto:d...@cpanel.net>> wrote: > > > > Hello, > > > > Was removing the major version from apache module done on purpose > > It was done on purpose on 28 Jan 2019 > https://github.com/php/php-src/pull/3769 > <https://github.com/php/php-src/pull/3769> > > Although it is annoying to have minor things like this change, > projects need to be able to correct small mistakes instead of leaving > them until the end of time. > > From elsewhere: > > Conclusion Let’s “Drop DSO in 8” for now, and if there is a large push to > > reinstate it, then > > revisit our options starting with the simpler “Patch PHP 8 to undo > > upstream’s change”. > > Sounds good to me. > > cheers > Dan > Ack > > FWIW, as the person who implemented the change, there was no very strong > reason to do it, it was just routine cleanup to drop major version numbers in > all places where they are not needed for technical reasons. (We used to have > hundreds of files that needed to be changed when the major version number > changed.) > > If I had known at the time, or really at any point in the following one and a > half years, that this causes issues for cpanel, I would have simply reverted > the change, because it would be more trouble than it is worth. However, as > the issue only came up pretty late, many other projects will have accounted > for the new name by now and would be broken if we changed it back. > > Regards, > Nikita -- Dan Muey➜cPanel::D3v::ZerØCool
