On 27/06/2020 23:53, G. P. B. wrote:
[...] there are only 3 parse errors which have the added information of what the token represents, namely T_SL, T_SR, and T_PAAMAYIM_NEKUDOTAYIM.
I'm not sure what you mean by there being only three. Since PHP 5.4, all parser errors include the content of the token as well as its name, even when this is basically repeating the same word, such as "unexpected 'echo' (T_ECHO)". There's even a bug in the implementation meaning that casts repeat the name three times, e.g. "unexpected '(int)' (int) (T_INT_CAST)".
This is why I was able to get a working prototype for new error messages fairly quickly, and have had a draft PR open for nearly two weeks, but also why I've spent a bit of time refining it to make sure edge cases are handled better.
I find it highly frustrating, and borderline offensive, that we are being asked to go from a simple, non BC breaking, easy to enact change, to a semi-major overhaul of how error messages should look like.
I understand the general sentiment, that there were a lot of people in the previous thread saying re-wording was a good idea, and not many offering to work on it. I also appreciate that I hadn't provided any public updates on my progress, and what hurdles needed to be over-come. But you did know I was working on a patch, so the simple solution would have been to ask me before opening the vote.
Regards, -- Rowan Tommins (né Collins) [IMSoP] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
