On Fri, Jun 5, 2020 at 5:42 PM Max Semenik <maxsem.w...@gmail.com> wrote:
> I was thinking about making some improvements to our venerable test runner, > however I wasn't feeling confident about improving the present code base. > Instead, I decided to attempt to refactor it. > > Here's my work in progress: https://github.com/MaxSem/run-tests > > It requires Composer only for development, and has a script to make a > single-file distribution, functionally identical to what we presently have. > > When it comes to integration with php-src, it could be moved to a > subdirectory there or be kept in a separate repository and be used to > generate a new run-tests.php whenever needed. > > Is there interest in this, should I continue? Any suggestions? > Happy to accept run-tests refactorings in general (there is a lot of global state to eradicate!), but please keep it single-file. We definitely need it single-file for distribution purposes, and I don't particularly want to have a "run-tests build system" for what I perceive to be little benefit. I'm not sure why PHP developers in particular seem to be so hung up about this issue, but: There really is no need to split every class into a separate file. This is how we develop in non-PHP, non-Java languages (C/C++/Rust/...) all the time. Regards, Nikita