On Wed, 14 Jul 2004, Kamesh Jayachandran wrote: > Hi Derick, > Thanks for responding. > I am posting my patches module by module. > For zend you can find the patches at the following locations. > http://puggy.symonds.net/~kameshj/zendnetwarepatches.tar.gz
1. This patch is the wrong way around (you swapped old and new in the diff command). 2. Tons of whitespace is introduced (bad idea to mix with code changes) 3. I think you screwed up line ending problems, all our code has Unix style line endinds. other than that it looks okay, though I'm not sure if we need too those really long comments in the code. regards, Derick -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
