On Fri, 23 Apr 2004, Andi Gutmans wrote: > At 03:01 PM 4/23/2004 +0100, Joe Orton wrote: > >On Fri, Apr 23, 2004 at 04:59:27PM +0300, Andi Gutmans wrote: > > > If at all, I think this should be fixed in PHP so that it affects all > > SAPIs > > > (i.e. first time we set umask() save the old one and a flag that let's > > > RSHUTDOWN know it should change it back). > > > >(In case it wasn't clear, all my patch did was copy the logic used by > >sapi/apache) > > Yeah, but I don't think this should be solved on the SAPI level but in the > PHP extension level (why not let it propagate to all SAPIs?). (Yeah, MT > servers are screwed when it comes to umask anyway). > Anyone disagree? If not, I suggest moving the logic from sapi/apache to Ext > Standard.
Makes sense to move it. There is a comment in the current umask code suggesting this should probably be done. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
