On Wed, 21 Apr 2004, Andi Gutmans wrote:
> >My patch is "nice" at this stage in the release because it is a > >minimal change that can't hurt anything; tweaking the passthru > >code is a bit more worrying :/ > > In that case, I'd put a hardcoded limit after which you fallback to > non-mmap()'ed reading and not add an INI option. Then you can add the > tweaked code when you have time/energy.
I would go for an INI setting because I can imagine situations were you'd want to even lower this (hardcoded) 8MB limit to say 1MB before falling back to non-mmap code.
So go for a 1MB limit until we improve the code. I don't think we should add an INI setting if this is something we will eventually solve in our code.
Andi
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
