On Tue, 26 Aug 2003, Sascha Schumann wrote:
> On Mon, 25 Aug 2003, Rasmus Lerdorf wrote: > > > It would also have to be a new 4.4 branch as it breaks binary > > compatibility for extensions. > > It is far from being usable in mainstream as it relies on various > GCC features in many places. Of course, using portable C is > a requirement for being accepted into the repository. I > suppose the patch authors are aware of that which is why they > have not come forward yet.
As long as there are appropriate checks and fallbacks, I see no problem using compiler-specific hacks. Especially in cases where it would benefit a large percentage of users.
I agree with Sascha. I actually did this patch on my own a few months ago and didn't feel that the performance improvement was good enough to make the code quite a bit less maintainable. It also makes execute() uglier because you need an entry point into execute to retrieve the addresses. In any case, it doesn't fit into the PHP 5 architecture of using a function call per-opcode.
Some of their other patches are nice and I will look into them.
Andi
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
