As far as I can tell your patch would not have any affect on existing *nix based code. So, the only possibility is either a working pspell extension for windows or a broken one. The latter would not be an issue since we didn't have such an extension before anyway.
I'll talk to Edin who is our win32 build master about the possibility of building pspell on win32, if it is practical then we can MFH the fix. Ilia On August 13, 2003 03:34 pm, Vlad Krupin wrote: > I wasn't really intending for it to be there since it is in RC stage, > and this is technically "new functionality". I thought it is "too late", > but, if not, I'll do that. There are only a few lines of code to backport. > > My big question is how to get the code to be in win32 snapshots and > ultimately in a release though. > > Vlad > > Ilia Alshanetsky wrote: > > Vald, > > > > If you want it to be part of the 4.3.3 release, you need to backport your > > changed to PHP_4_3 branch. > > > > Ilia > > > > On August 13, 2003 03:19 pm, Vlad Krupin wrote: > >>Ok, looks like all win32 experts are on vacation, or have no opinion. > >>I've implemented win32 build to the best of my knowledge, and it works. > >>I committed it, along with the .dsp file. But I still want to figure out > >>how to make sure that php_pspell.dll gets built and included into next > >>PHP release. > >> > >>Somebody who does windows builds, please, could you tell me what I need > >>to do to get pspell into win32 snapshots builds? I imagine, we need: > >> > >>1) install pspell includes and libraries on a build machine, so we can > >>link to them > >>2) add pspell to the build > >>3) add ';extension=php_pspell.dll' to php.ini-* files > >> > >>Thanks in advance, > >> > >>Vlad > >> > >>Vlad Krupin wrote: > >>>Hi, internals, > >>> > >>>I need some help with my attempt to provide win32 port for the > >>>spellchecker (pspell extension). Since I am pretty ignorant as far as > >>>win32 goes, can some kind win32 guru answer this?: > >>> > >>>1. The spellchecker has dictionaries that are located somewhere on the > >>>system and there is a registry key pointing to that place. PHP needs to > >>>know where they are. We can > >>> a) read it from the registry every time we open a new dictionary > >>> b) create an ini option for that (I know that nobody likes making > >>>php.ini even larger) > >>> c) force the developer provide a path (extra hassle, and the scripts > >>>won't be very portable between windows and other OSes, so I'd rather not > >>>do it) > >>>What is the best way to do it? > >>> > >>>2. What needs to be done to make sure the new dll gets built and > >>>distributed along with other extensions with the next releae of PHP? I > >>>assume that whoever does those win32 builds needs to know how to install > >>>the spellchecker, where to get the library, etc. > >>> > >>>Thanks, > >>> > >>>Vlad -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
