> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Alok Tiwari
> Sent: Monday, November 3, 2025 10:03 AM
> To: Kitszel, Przemyslaw <[email protected]>; Lobakin,
> Aleksander <[email protected]>; Nguyen, Anthony L
> <[email protected]>; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH net-next] iavf: clarify VLAN
> add/delete log messages and lower log level
>
> The current dev_warn messages for too many VLAN changes are confusing
> and one place incorrectly reference "add" instead of "delete" VLANs
> due to copy-paste errors.
>
> - Use dev_info instead of dev_warn to lower the log level.
> - Rephrase the message to: "Too many VLAN [add|delete] changes
> requested,
> splitting into multiple messages to PF".
>
> Suggested-by: Przemek Kitszel <[email protected]>
> Signed-off-by: Alok Tiwari <[email protected]>
> ---
> https://lore.kernel.org/all/47f8c95c-bac4-471f-8e58-
> [email protected]/
> ---
> drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> index 34a422a4a29c..3593c0b45cf7 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
> @@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>
> len = virtchnl_struct_size(vvfl, vlan_id, count);
> if (len > IAVF_MAX_AQ_BUF_SIZE) {
> - dev_warn(&adapter->pdev->dev, "Too many add VLAN
> changes in one request\n");
> + dev_info(&adapter->pdev->dev, "Too many VLAN add
> changes requested,\n"
> + "splitting into multiple messages to
> PF\n");
> while (len > IAVF_MAX_AQ_BUF_SIZE)
> len = virtchnl_struct_size(vvfl, vlan_id,
> --count);
> @@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
>
> len = virtchnl_struct_size(vvfl_v2, filters, count);
> if (len > IAVF_MAX_AQ_BUF_SIZE) {
> - dev_warn(&adapter->pdev->dev, "Too many add VLAN
> changes in one request\n");
> + dev_info(&adapter->pdev->dev, "Too many VLAN add
> changes requested,\n"
> + "splitting into multiple messages to
> PF\n");
Kernel style prefers single-line messages unless absolutely necessary.
Multi-line dev_info() is unusual for simple info.
dev_info() is acceptable for non-critical conditions, but consider
netdev_info() for network-related messages (common in drivers).
...
