On Fri, Sep 05, 2025 at 07:52:13PM +0000, Loktionov, Aleksandr wrote: > > > > -----Original Message----- > > From: Intel-wired-lan <[email protected]> On Behalf > > Of Alok Tiwari > > Sent: Friday, September 5, 2025 6:34 PM > > To: Nguyen, Anthony L <[email protected]>; Kitszel, > > Przemyslaw <[email protected]>; [email protected]; > > [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected]; > > [email protected] > > Cc: [email protected] > > Subject: [Intel-wired-lan] [PATCH net-next] ixgbe: fix typo in > > function comment for ixgbe_get_num_per_func() > > > > Correct a typo in the comment where "PH" was used instead of "PF". > > The function returns the number of resources per PF or 0 if no PFs are > > available. > > > > Signed-off-by: Alok Tiwari <[email protected]>
Hi Aleksandr, Perhaps I need more coffee. But it's unclear to me why you responded to the above with the patch below. > From: Qiang Liu <[email protected]> > > After obtaining the register value via raw_desc, > redundant self-assignment operations can be removed. > > Signed-off-by: Qiang Liu <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c > b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c > index bfeef5b0b99d..6efedf04a963 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c > @@ -143,18 +143,14 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw > *hw, > > /* Read sync Admin Command response */ > if ((hicr & IXGBE_PF_HICR_SV)) { > - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) { > + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) > raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i)); > - raw_desc[i] = raw_desc[i]; > - } > } > > /* Read async Admin Command response */ > if ((hicr & IXGBE_PF_HICR_EV) && !(hicr & IXGBE_PF_HICR_C)) { > - for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) { > + for (i = 0; i < IXGBE_ACI_DESC_SIZE_IN_DWORDS; i++) > raw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i)); > - raw_desc[i] = raw_desc[i]; > - } > } > > /* Handle timeout and invalid state of HICR register */ > -- > 2.43.0 ...
