Re: [Intel-wired-lan] [PATCH net-next v3 4/4] net/mlx5e: Report RS-FEC histogram statistics via ethtool

[Jakub Kicinski]

On Tue, 16 Sep 2025 19:12:57 +0000 Vadim Fedorenko wrote:
> +     for (int i = 0; i < num_of_bins; i++) {

brackets unnecessary

in the other patch you picked u8 for i, good to be consistent
(int is better)

> +             hist->values[i].bin_value = MLX5_GET64(rs_histogram_cntrs,
> +                                                    rs_histogram_cntrs,
> +                                                    hist[i]);

could also be written as:

                hist->values[i].bin_value =
                        MLX5_GET64(rs_histogram_cntrs, rs_histogram_cntrs, 
hist[i]);