On Wed, 13 Aug 2025 21:55:48 +0300 Tariq Toukan wrote: > diff --git a/Documentation/netlink/specs/devlink.yaml > b/Documentation/netlink/specs/devlink.yaml > index bb87111d5e16..0e81640dd3b2 100644 > --- a/Documentation/netlink/specs/devlink.yaml > +++ b/Documentation/netlink/specs/devlink.yaml > @@ -853,6 +853,9 @@ attribute-sets: > type: nest > multi-attr: true > nested-attributes: dl-rate-tc-bws > + - > + name: health-reporter-error-burst-period
the "graceful-period" does not have the word "error" in it. Why is it necessary to include it in this parameter? What else would be bursting in an error reporter if not errors? > + type: u64 could you add a doc: here? > - > name: dl-dev-stats > subset-of: devlink > + DEVLINK_ATTR_HEALTH_REPORTER_ERR_BURST_PERIOD, /* u64 */ The _ERR here won't work if you used _ERROR in YAML. The naming in the YAML spec must match the C naming exactly. -- pw-bot: cr
