On 8/12/25 22:07, Paul Menzel wrote:
Dear Przemek,


Thank you for your patch.

Am 12.08.25 um 15:29 schrieb Przemek Kitszel:
Add copy of ice_virtchnl.c under the original name/location.

Why not mention the rename in the summary/title instead of p2?

that was "technical git detail", that is gone after the full series is
applied, anyway, I could apply:
        s/p1/tmp rename/;s/p2/copy back/
(but would rather avoid sending whole series again on IWL just for that)

for "cleanup - pX" commits I would keep title as-is, as those were split
only to avoid git creativity in minimizing the diff


Now both ice_virtchnl.c and ice_virtchnl_queues.c have the same content,
and only the former of the two in use.

Signed-off-by: Przemek Kitszel <[email protected]>
---
  drivers/net/ethernet/intel/ice/Makefile       |    2 +-
  drivers/net/ethernet/intel/ice/ice_virtchnl.c | 4611 +++++++++++++++++
  2 files changed, 4612 insertions(+), 1 deletion(-)
  create mode 100644 drivers/net/ethernet/intel/ice/ice_virtchnl.c

[…]

Reviewed-by: Paul Menzel <[email protected]>

thank you!



Kind regards,

Paul

Reply via email to