> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Dave Ertman
> Sent: Monday, June 16, 2025 4:33 PM
> To: [email protected]
> Cc: Kitszel, Przemyslaw <[email protected]>; Loktionov,
> Aleksandr <[email protected]>; Marcin Szycik
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next v4 6/8] [PATCH iwl-next v3 6/8]
> ice:
> cleanup capabilities evaluation
>
> When evaluating the capabilities field, the ICE_AQC_BIT_ROCEV2_LAG and
> ICE_AQC_BIT_SRIOV_LAG defines were both not using the BIT operator,
> instead simply setting a hex value that set the correct bits. While not
> inaccurate, this method is misleading, and when it is expanded in the
> following implementation it becomes even more confusing.
>
> Switch to using the BIT() operator to clarify what is being checked.
>
> Reviewed-by: Przemek Kitszel <[email protected]>
> Reviewed-by: Aleksandr Loktionov <[email protected]>
> Reviewed-by: Marcin Szycik <[email protected]>
> Signed-off-by: Dave Ertman <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Tested-by: Sujai Buvaneswaran <[email protected]>
