On Wed, 30 Jul 2025 10:22:36 +0100 Vadim Fedorenko wrote:
> >> + name: fec-hist
> >> + subset-of: fec-stat
> >
> > no need to make this a subset, better to make it its own attr set
>
> like a set for general histogram? or still fec-specific?
You can make it a general histogram, I guess 🤔️
No strong preference.
> >> + attributes:
> >> + -
> >> + name: fec-hist-bin-low
> >> + -
> >> + name: fec-hist-bin-high
> >> + -
> >> + name: fec-hist-bin-val
> >> -
> >> name: fec
> >> attr-cnt-name: __ethtool-a-fec-cnt
> >
> >> +static const struct ethtool_fec_hist_range netdevsim_fec_ranges[] = {
> >> + { 0, 0},
> >> + { 1, 3},
> >> + { 4, 7},
> >> + { -1, -1}
> >> +};
> >
> > Let's add a define for the terminating element?
>
> I believe it's about (-1, -1) case. If we end up using (0, 0) then there
> is no need to define anything, right?
Yup, 0,0 is better written as {} so no need for a define.
