Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report

[Andrew Lunn]

> +        name: fec-hist-bin-low
> +        type: s32

Signed 32 bit

> +struct ethtool_fec_hist_range {
> +     s16 low;

Signed 16 bit.

> +             if (nla_put_u32(skb, ETHTOOL_A_FEC_STAT_FEC_HIST_BIN_LOW,
> +                             ranges[i].low) ||

Unsigned 32 bit.

Could we have some consistency with the types.

        Andrew