> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Kohei Enju
> Sent: Thursday, June 12, 2025 6:14 PM
> To: Nguyen, Anthony L <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>
> Cc: [email protected]; [email protected]; Andrew
> Lunn <[email protected]>; David S . Miller <[email protected]>;
> Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>;
> Paolo Abeni <[email protected]>; Kohei Enju <[email protected]>;
> Kohei Enju <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1] igbvf: remove unused
> interrupt counter fields from struct igbvf_adapter
>
> Remove `int_counter0` and `int_counter1` from struct igbvf_adapter
> since they are only incremented in interrupt handlers
> igbvf_intr_msix_rx() and igbvf_msix_other(), but never read or used
> anywhere in the driver.
>
> Note that igbvf_intr_msix_tx() does not have similar counter
> increments, suggesting that these were likely overlooked during
> development.
>
> Eliminate the fields and their unnecessary accesses in interrupt
> handlers.
>
> Tested-by: Kohei Enju <[email protected]>
> Signed-off-by: Kohei Enju <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
> ---
> drivers/net/ethernet/intel/igbvf/igbvf.h | 2 --
> drivers/net/ethernet/intel/igbvf/netdev.c | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igbvf/igbvf.h
> b/drivers/net/ethernet/intel/igbvf/igbvf.h
> index ca6e44245a7b..ba9c3fee6da7 100644
> --- a/drivers/net/ethernet/intel/igbvf/igbvf.h
> +++ b/drivers/net/ethernet/intel/igbvf/igbvf.h
> @@ -238,8 +238,6 @@ struct igbvf_adapter {
> int int_mode;
> u32 eims_enable_mask;
> u32 eims_other;
> - u32 int_counter0;
> - u32 int_counter1;
>
> u32 eeprom_wol;
> u32 wol;
> diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c
> b/drivers/net/ethernet/intel/igbvf/netdev.c
> index beb01248600f..33104408007a 100644
> --- a/drivers/net/ethernet/intel/igbvf/netdev.c
> +++ b/drivers/net/ethernet/intel/igbvf/netdev.c
> @@ -855,8 +855,6 @@ static irqreturn_t igbvf_msix_other(int irq, void
> *data)
> struct igbvf_adapter *adapter = netdev_priv(netdev);
> struct e1000_hw *hw = &adapter->hw;
>
> - adapter->int_counter1++;
> -
> hw->mac.get_link_status = 1;
> if (!test_bit(__IGBVF_DOWN, &adapter->state))
> mod_timer(&adapter->watchdog_timer, jiffies + 1); @@ -
> 899,8 +897,6 @@ static irqreturn_t igbvf_intr_msix_rx(int irq, void
> *data)
> struct net_device *netdev = data;
> struct igbvf_adapter *adapter = netdev_priv(netdev);
>
> - adapter->int_counter0++;
> -
> /* Write the ITR value calculated at the end of the
> * previous interrupt.
> */
> --
> 2.49.0
