On 3/21/25 10:52, luoxuanqiang wrote:
From: luoxuanqiang <luoxuanqi...@kylinos.cn>As mentioned in the commit baeb705fd6a7 ("ice: always check VF VSI pointer values"), we need to perform a null pointer check on the return value of ice_get_vf_vsi() before using it. Fixes: 6ebbe97a4881 ("ice: Add a per-VF limit on number of FDIR filters") Signed-off-by: luoxuanqiang <xuanqiang....@linux.dev>
Thank you for your patch, it looks good. To apply it you have to provide us your name in the format: Firstname Surname (or similar, could include more than 2 words) please also CC IWL mailing list (CC'd by me) to have faster feedback :) would be best if you put [PATCH iwl-net v2] in the subject
--- drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c index 14e3f0f89c78..53bad68e3f38 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_fdir.c @@ -2092,6 +2092,12 @@ int ice_vc_add_fdir_fltr(struct ice_vf *vf, u8 *msg) dev = ice_pf_to_dev(pf); vf_vsi = ice_get_vf_vsi(vf);+ if (!vf_vsi) {+ dev_err(dev, "Can not get FDIR vf_vsi for VF %u\n", vf->vf_id); + v_ret = VIRTCHNL_STATUS_ERR_PARAM; + goto err_exit; + } + #define ICE_VF_MAX_FDIR_FILTERS 128 if (!ice_fdir_num_avail_fltr(&pf->hw, vf_vsi) || vf->fdir.fdir_fltr_cnt_total >= ICE_VF_MAX_FDIR_FILTERS) {
