On Mon Mar 10 2025, Joe Damato wrote: > On Fri, Mar 07, 2025 at 02:03:44PM -0800, Tony Nguyen wrote: >> On 2/17/2025 3:31 AM, Kurt Kanzenbach wrote: >> >> ... >> >> > diff --git a/drivers/net/ethernet/intel/igb/igb_xsk.c >> > b/drivers/net/ethernet/intel/igb/igb_xsk.c >> > index >> > 157d43787fa0b55a74714f69e9e7903b695fcf0a..a5ad090dfe94b6afc8194fe39d28cdd51c7067b0 >> > 100644 >> > --- a/drivers/net/ethernet/intel/igb/igb_xsk.c >> > +++ b/drivers/net/ethernet/intel/igb/igb_xsk.c >> > @@ -45,6 +45,7 @@ static void igb_txrx_ring_disable(struct igb_adapter >> > *adapter, u16 qid) >> > synchronize_net(); >> > /* Rx/Tx share the same napi context. */ >> > + igb_set_queue_napi(adapter, qid, NULL); >> > napi_disable(&rx_ring->q_vector->napi); >> > igb_clean_tx_ring(tx_ring); >> > @@ -78,6 +79,7 @@ static void igb_txrx_ring_enable(struct igb_adapter >> > *adapter, u16 qid) >> > /* Rx/Tx share the same napi context. */ >> > napi_enable(&rx_ring->q_vector->napi); >> > + igb_set_queue_napi(adapter, qid, &rx_ring->q_vector->napi); >> > } >> > struct xsk_buff_pool *igb_xsk_pool(struct igb_adapter *adapter, >> >> I believe Joe's fix/changes [1] need to be done here as well? >> >> Thanks, >> Tony >> >> [1] >> https://lore.kernel.org/intel-wired-lan/9ddf6293-6cb0-47ea-a0e7-cad7d33c2...@intel.com/T/#m863614df1fb3d1980ad09016b1c9ef4e2f0b074e > > Yes, the code above should be dropped. Sorry I missed that during > review - thanks for catching that, Tony. > > Kurt: when you respin this to fix what Tony mentioned, can you also > run the test mentioned above?
Hi Tony & Joe, Hm. I did run the test and it succeeded. I'll take a look at it next week when I'm back in the office. Thanks, Kurt
signature.asc
Description: PGP signature
