Subject: Re: [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter 
index

regarding -net vs -next, no one have complained that this bug hurts

+       return (unsigned long)pci_get_dsn(pdev);

How do you ensure there is no xarray index collision then you cut the number 
like this?

The reduction occurs only on "32b" systems, which are unlikely to have
this device. And any mixing of the upper and lower 4B part still could
collide.


It is also probably necessary to check if all devices supported by the driver 
have DSN capability enabled.

I will double check on the SoC you have in mind.


Regards,
Sergey

Reply via email to