On Tue Mar 04 2025, Simon Horman wrote: > On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote: >> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In >> this mode the hardware uses four packet buffers and considers queue >> priorities. >> >> In order to harmonize the TAPRIO implementation with MQPRIO, switch to the >> regular TSN Tx mode. This mode also uses four packet buffers and considers >> queue priorities. In addition to the legacy mode, transmission is always >> coupled to Qbv. The driver already has mechanisms to use a dummy schedule >> of 1 second with all gates open for ETF. Simply use this for MQPRIO too. >> >> This reduces code and makes it easier to add support for frame preemption >> later. >> >> While at it limit the netdev_tc calls to MQPRIO only. > > Hi Kurt, > > Can this part be broken out into a separate patch? > It seems so to me, but perhaps I'm missing something. > > The reason that I ask is that this appears to be a good portion of the > change, and doing so would make the code changes for main part of the > patch, as per the description prior to the line above, clearer IMHO.
Sure, i think it can be broken out into a dedicated patch. I'll see what I can come up with. Thanks, Kurt
signature.asc
Description: PGP signature
