>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Thursday, January 23, 2025 8:31 PM
>To: intel-wired-...@lists.osuosl.org
>Cc: Fijalkowski, Maciej <maciej.fijalkow...@intel.com>;
>net...@vger.kernel.org; x...@redhat.com; Nguyen, Anthony L
><anthony.l.ngu...@intel.com>; Simon Horman <ho...@kernel.org>; Kitszel,
>Przemyslaw <przemyslaw.kits...@intel.com>; Keller, Jacob E
><jacob.e.kel...@intel.com>; Maxwell, Jon <jmaxw...@redhat.com>; Karlsson,
>Magnus <magnus.karls...@intel.com>
>Subject: [Intel-wired-lan] [PATCH v5 iwl-net 1/3] ice: put Rx buffers after
>being
>done with current frame
>
>Introduce a new helper ice_put_rx_mbuf() that will go through gathered frags
>from current frame and will call ice_put_rx_buf() on them. Current logic that
>was supposed to simplify and optimize the driver where we go through a batch
>of all buffers processed in current NAPI instance turned out to be broken for
>jumbo frames and very heavy load that was coming from both multi-thread
>iperf and nginx/wrk pair between server and client. The delay introduced by
>approach that we are dropping is simply too big and we need to take the
>decision regarding page recycling/releasing as quick as we can.
>
>While at it, address an error path of ice_add_xdp_frag() - we were missing
>buffer putting from day 1 there.
>
>As a nice side effect we get rid of annoying and repetitive three-liner:
>
> xdp->data = NULL;
> rx_ring->first_desc = ntc;
> rx_ring->nr_frags = 0;
>
>by embedding it within introduced routine.
>
>Fixes: 1dc1a7e7f410 ("ice: Centrallize Rx buffer recycling")
>Reported-and-tested-by: Xu Du <x...@redhat.com>
>Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
>Reviewed-by: Simon Horman <ho...@kernel.org>
>Co-developed-by: Jacob Keller <jacob.e.kel...@intel.com>
>Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com>
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkow...@intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_txrx.c | 79 ++++++++++++++---------
> 1 file changed, 50 insertions(+), 29 deletions(-)
>
Tested-by: Chandan Kumar Rout <chandanx.r...@intel.com> (A Contingent Worker at
Intel)
