Hi Maciej, kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-net-queue/dev-queue] url: https://github.com/intel-lab-lkp/linux/commits/Maciej-Fijalkowski/ice-put-Rx-buffers-after-being-done-with-current-frame/20250120-235320 base: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue patch link: https://lore.kernel.org/r/20250120155016.556735-4-maciej.fijalkowski%40intel.com patch subject: [Intel-wired-lan] [PATCH v3 iwl-net 3/3] ice: stop storing XDP verdict within ice_rx_buf config: arc-randconfig-001-20250121 (https://download.01.org/0day-ci/archive/20250121/202501210750.kinytrpt-...@intel.com/config) compiler: arceb-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250121/202501210750.kinytrpt-...@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <l...@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202501210750.kinytrpt-...@intel.com/ All warnings (new ones prefixed by >>): >> drivers/net/ethernet/intel/ice/ice_txrx.c:539: warning: Excess function >> parameter 'rx_buf' description in 'ice_run_xdp' vim +539 drivers/net/ethernet/intel/ice/ice_txrx.c cdedef59deb020 Anirudh Venkataramanan 2018-03-20 523 efc2214b6047b6 Maciej Fijalkowski 2019-11-04 524 /** efc2214b6047b6 Maciej Fijalkowski 2019-11-04 525 * ice_run_xdp - Executes an XDP program on initialized xdp_buff efc2214b6047b6 Maciej Fijalkowski 2019-11-04 526 * @rx_ring: Rx ring efc2214b6047b6 Maciej Fijalkowski 2019-11-04 527 * @xdp: xdp_buff used as input to the XDP program efc2214b6047b6 Maciej Fijalkowski 2019-11-04 528 * @xdp_prog: XDP program to run eb087cd828648d Maciej Fijalkowski 2021-08-19 529 * @xdp_ring: ring to be used for XDP_TX action 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 530 * @rx_buf: Rx buffer to store the XDP action d951c14ad237b0 Larysa Zaremba 2023-12-05 531 * @eop_desc: Last descriptor in packet to read metadata from efc2214b6047b6 Maciej Fijalkowski 2019-11-04 532 * efc2214b6047b6 Maciej Fijalkowski 2019-11-04 533 * Returns any of ICE_XDP_{PASS, CONSUMED, TX, REDIR} efc2214b6047b6 Maciej Fijalkowski 2019-11-04 534 */ 55a1a17189d7a5 Maciej Fijalkowski 2025-01-20 535 static u32 e72bba21355dbb Maciej Fijalkowski 2021-08-19 536 ice_run_xdp(struct ice_rx_ring *rx_ring, struct xdp_buff *xdp, 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 537 struct bpf_prog *xdp_prog, struct ice_tx_ring *xdp_ring, 55a1a17189d7a5 Maciej Fijalkowski 2025-01-20 538 union ice_32b_rx_flex_desc *eop_desc) efc2214b6047b6 Maciej Fijalkowski 2019-11-04 @539 { 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 540 unsigned int ret = ICE_XDP_PASS; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 541 u32 act; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 542 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 543 if (!xdp_prog) 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 544 goto exit; 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 545 d951c14ad237b0 Larysa Zaremba 2023-12-05 546 ice_xdp_meta_set_desc(xdp, eop_desc); d951c14ad237b0 Larysa Zaremba 2023-12-05 547 efc2214b6047b6 Maciej Fijalkowski 2019-11-04 548 act = bpf_prog_run_xdp(xdp_prog, xdp); efc2214b6047b6 Maciej Fijalkowski 2019-11-04 549 switch (act) { efc2214b6047b6 Maciej Fijalkowski 2019-11-04 550 case XDP_PASS: 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 551 break; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 552 case XDP_TX: 22bf877e528f68 Maciej Fijalkowski 2021-08-19 553 if (static_branch_unlikely(&ice_xdp_locking_key)) 22bf877e528f68 Maciej Fijalkowski 2021-08-19 554 spin_lock(&xdp_ring->tx_lock); 055d0920685e53 Alexander Lobakin 2023-02-10 555 ret = __ice_xmit_xdp_ring(xdp, xdp_ring, false); 22bf877e528f68 Maciej Fijalkowski 2021-08-19 556 if (static_branch_unlikely(&ice_xdp_locking_key)) 22bf877e528f68 Maciej Fijalkowski 2021-08-19 557 spin_unlock(&xdp_ring->tx_lock); 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 558 if (ret == ICE_XDP_CONSUMED) 89d65df024c599 Magnus Karlsson 2021-05-10 559 goto out_failure; 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 560 break; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 561 case XDP_REDIRECT: 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 562 if (xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog)) 89d65df024c599 Magnus Karlsson 2021-05-10 563 goto out_failure; 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 564 ret = ICE_XDP_REDIR; 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 565 break; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 566 default: c8064e5b4adac5 Paolo Abeni 2021-11-30 567 bpf_warn_invalid_xdp_action(rx_ring->netdev, xdp_prog, act); 4e83fc934e3a04 Bruce Allan 2020-01-22 568 fallthrough; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 569 case XDP_ABORTED: 89d65df024c599 Magnus Karlsson 2021-05-10 570 out_failure: efc2214b6047b6 Maciej Fijalkowski 2019-11-04 571 trace_xdp_exception(rx_ring->netdev, xdp_prog, act); 4e83fc934e3a04 Bruce Allan 2020-01-22 572 fallthrough; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 573 case XDP_DROP: 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 574 ret = ICE_XDP_CONSUMED; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 575 } 1dc1a7e7f4108b Maciej Fijalkowski 2023-01-31 576 exit: 55a1a17189d7a5 Maciej Fijalkowski 2025-01-20 577 return ret; efc2214b6047b6 Maciej Fijalkowski 2019-11-04 578 } efc2214b6047b6 Maciej Fijalkowski 2019-11-04 579 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
