> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of Simon > Horman > Sent: Monday, January 6, 2025 11:24 AM > To: Kitszel, Przemyslaw <przemyslaw.kits...@intel.com> > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > <anthony.l.ngu...@intel.com>; net...@vger.kernel.org; Dan Carpenter > <dan.carpen...@linaro.org>; Zaki, Ahmed <ahmed.z...@intel.com>; Zaremba, > Larysa <larysa.zare...@intel.com> > Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3] ice: fix > ice_parser_rt::bst_key > array size > > On Thu, Dec 19, 2024 at 12:55:16PM +0100, Przemek Kitszel wrote: > > Fix &ice_parser_rt::bst_key size. It was wrongly set to 10 instead of > > 20 in the initial impl commit (see Fixes tag). All usage code assumed > > it was of size 20. That was also the initial size present up to v2 of > > the intro series [2], but halved by v3 [3] refactor described as > > "Replace magic hardcoded values with macros." The introducing series > > was so big that some ugliness was unnoticed, same for bugs :/ > > > > ICE_BST_KEY_TCAM_SIZE and ICE_BST_TCAM_KEY_SIZE were differing by one. > > There was tmp variable @j in the scope of edited function, but was not > > used in all places. This ugliness is now gone. > > I'm moving ice_parser_rt::pg_prio a few positions up, to fill up one > > of the holes in order to compensate for the added 10 bytes to the > > ::bst_key, resulting in the same size of the whole as prior to the > > fix, and miminal changes in the offsets of the fields. > > > > Extend also the debug dump print of the key to cover all bytes. To not > > have string with 20 "%02x" and 20 params, switch to > > ice_debug_array_w_prefix(). > > > > This fix obsoletes Ahmed's attempt at [1]. > > > > [1] > > https://lore.kernel.org/intel-wired-lan/20240823230847.172295-1-ahmed. > > z...@intel.com [2] > > https://lore.kernel.org/intel-wired-lan/20230605054641.2865142-13-junf > > eng....@intel.com [3] > > https://lore.kernel.org/intel-wired-lan/20230817093442.2576997-13-junf > > eng....@intel.com > > > > Reported-by: Dan Carpenter <dan.carpen...@linaro.org> > > Closes: > > https://lore.kernel.org/intel-wired-lan/b1fb6ff9-b69e-4026-9988-3c783d > > 86c2e0@stanley.mountain > > Fixes: 9a4c07aaa0f5 ("ice: add parser execution main loop") > > CC: Ahmed Zaki <ahmed.z...@intel.com> > > Reviewed-by: Larysa Zaremba <larysa.zare...@intel.com> > > Signed-off-by: Przemek Kitszel <przemyslaw.kits...@intel.com> > > --- > > v3: mention printing change in commit msg, separate prefix from the > > debug log (Simon) > > > > v2: same as v3, but lacks code change :( > > > > v1: > > https://lore.kernel.org/intel-wired-lan/20241216170548.GI780307@kernel > > .org/T/#mbf984a0faa12a5bdb53460b150201fdd7cc1826a > > Thanks for the updates, much appreciated. > > Reviewed-by: Simon Horman <ho...@kernel.org>
Tested-by: Rafal Romanowski <rafal.romanow...@intel.com>
