On 2025-01-10 4:55 a.m., Simon Horman wrote:
On Thu, Jan 09, 2025 at 04:31:03PM -0700, Ahmed Zaki wrote:
For drivers using the netif_enable_cpu_rmap(), move the IRQ rmap notifier
inside the napi_struct.
Signed-off-by: Ahmed Zaki <ahmed.z...@intel.com>
...
diff --git a/net/core/dev.c b/net/core/dev.c
...
+static int napi_irq_cpu_rmap_add(struct napi_struct *napi, int irq)
+{
+ struct cpu_rmap *rmap = napi->dev->rx_cpu_rmap;
+ int rc;
+
+ if (!napi || !rmap)
+ return -EINVAL;
Hi Ahmed,
Here it is assumed that napi may be NULL. But it is dereferenced
unconditionally on the first like of this function.
Flagged by Smatch.
Correct. This was probably a defensive check, I will remove it since the
caller already dereferences the napi ptr.
Thanks for the review.
Ahmed
