> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Wander Lairson Costa > Sent: Wednesday, December 4, 2024 12:42 PM > To: Nguyen, Anthony L <anthony.l.ngu...@intel.com>; Kitszel, Przemyslaw > <przemyslaw.kits...@intel.com>; Andrew Lunn <andrew+net...@lunn.ch>; > David S. Miller <da...@davemloft.net>; Eric Dumazet > <eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo Abeni > <pab...@redhat.com>; Sebastian Andrzej Siewior <bige...@linutronix.de>; Clark > Williams <clrkwl...@kernel.org>; Steven Rostedt <rost...@goodmis.org>; Auke > Kok <auke-jan.h....@intel.com>; Jeff Garzik <jgar...@redhat.com>; moderated > list:INTEL ETHERNET DRIVERS <intel-wired-...@lists.osuosl.org>; open > list:NETWORKING DRIVERS <net...@vger.kernel.org>; open list <linux- > ker...@vger.kernel.org>; open list:Real-time Linux > (PREEMPT_RT):Keyword:PREEMPT_RT <linux-rt-de...@lists.linux.dev> > Cc: Wander Lairson Costa <wan...@redhat.com> > Subject: [Intel-wired-lan] [PATCH iwl-net 1/4] igb: narrow scope of vfs_lock > in SR- > IOV cleanup > > The adapter->vfs_lock currently protects critical sections shared between > igb_disable_sriov() and igb_msg_task(). Since igb_msg_task() — which is > invoked > solely by the igb_msix_other() ISR—only proceeds when > adapter->vfs_allocated_count > 0, we can reduce the lock scope further. > > By moving the assignment adapter->vfs_allocated_count = 0 to the start of the > cleanup code in igb_disable_sriov(), we can restrict the spinlock protection > solely > to this assignment. This change removes kfree() calls from within the locked > section, simplifying lock management. > > Once kfree() is outside the vfs_lock scope, it becomes possible to safely > convert > vfs_lock to a raw_spin_lock. > > Signed-off-by: Wander Lairson Costa <wan...@redhat.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c > b/drivers/net/ethernet/intel/igb/igb_main.c > index 08578980b6518..4ca25660e876e 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -3708,12 +3708,12 @@ static int igb_disable_sriov(struct pci_dev *pdev,
Tested-by: Rafal Romanowski <rafal.romanow...@intel.com>
