> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of
> Larysa Zaremba
> Sent: Wednesday, September 4, 2024 2:54 AM
> To: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L
> <anthony.l.ngu...@intel.com>
> Cc: Tantilov, Emil S <emil.s.tanti...@intel.com>; Zaremba, Larysa
> <larysa.zare...@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kits...@intel.com>; Hay, Joshua A <joshua.a....@intel.com>;
> linux-ker...@vger.kernel.org; Bagnucki, Igor <igor.bagnu...@intel.com>;
> Lobakin, Aleksander <aleksander.loba...@intel.com>; Eric Dumazet
> <eduma...@google.com>; Kubiak, Michal <michal.kub...@intel.com>; Alan
> Brady <alan.br...@intel.com>; net...@vger.kernel.org; Jakub Kicinski
> <k...@kernel.org>; Paolo Abeni <pab...@redhat.com>; David S. Miller
> <da...@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: deinit virtchnl transaction
> manager after vport and vectors
>
> When the device is removed, idpf is supposed to make certain virtchnl
> requests e.g. VIRTCHNL2_OP_DEALLOC_VECTORS and
> VIRTCHNL2_OP_DESTROY_VPORT.
>
> However, this does not happen due to the referenced commit introducing
> virtchnl transaction manager and placing its deinitialization before those
> messages are sent. Then the sending is impossible due to no transactions
> being available.
>
> Lack of cleanup can lead to the FW becoming unresponsive from e.g.
> unloading-loading the driver and creating-destroying VFs afterwards.
>
> Move transaction manager deinitialization to after other virtchnl-related
> cleanup is done.
>
> Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager")
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zare...@intel.com>
> ---
> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index a5f9b7a5effe..f18f490dafd8 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
Tested-by: Krishneil Singh <krishneil.k.si...@intel.com>
