> -----Original Message-----
> From: Dave Ertman <david.m.ert...@intel.com>
> Sent: Wednesday, September 18, 2024 11:03 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Kitszel, Przemyslaw <przemyslaw.kits...@intel.com>
> Subject: [PATCH iwl-net] ice: fix VLAN replay after reset
>
> There is a bug currently when there are more than one VLAN defined
> and any reset that affects the PF is initiated, after the reset rebuild
> no traffic will pass on any VLAN but the last one created.
>
> This is caused by the iteration though the VLANs during replay each
> clearing the vsi_map bitmap of the VSI that is being replayed. The
> problem is that during rhe replay, the pointer to the vsi_map bitmap
> is used by each successive vlan to determine if it should be replayed
> on this VSI.
>
> The logic was that the replay of the VLAN would replace the bit in the map
> before the next VLAN would iterate through. But, since the replay copies
> the old bitmap pointer to filt_replay_rules and creates a new one for the
> recreated VLANS, it does not do this, and leaves the old bitmap broken
> to be used to replay the remaining VLANs.
>
> Since the old bitmap will be cleaned up in post replay cleanup, there is
> no need to alter it and break following VLAN replay, so don't clear the
> bit.
>
> Fixes: 334cb0626de1 ("ice: Implement VSI replay framework")
> Reviewed-by: Przemek Kitszel <przemyslaw.kits...@intel.com>
> Signed-off-by: Dave Ertman <david.m.ert...@intel.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>
