On 9/2/2024 6:14 AM, Hongbo Li wrote:
> We have for some time the assign_bit() API to replace open coded
>
> if (foo)
> set_bit(n, bar);
> else
> clear_bit(n, bar);
>
> Use this API to clean the code. No functional change intended.
>
> Signed-off-by: Hongbo Li <lihongb...@huawei.com>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index 46d3c5a34d6a..e3ad91b3ba77 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -6522,8 +6522,7 @@ ice_set_features(struct net_device *netdev,
> netdev_features_t features)
> if (changed & NETIF_F_HW_TC) {
> bool ena = !!(features & NETIF_F_HW_TC);
>
> - ena ? set_bit(ICE_FLAG_CLS_FLOWER, pf->flags) :
> - clear_bit(ICE_FLAG_CLS_FLOWER, pf->flags);
> + assign_bit(ICE_FLAG_CLS_FLOWER, pf->flags, ena);
> }
>
> if (changed & NETIF_F_LOOPBACK)
Reviewed-by: Jacob Keller <jacob.e.kel...@intel.com>
