On Wed, 4 Sep 2024 15:53:46 +0200 Paolo Abeni wrote: > +static int iavf_verify_handle(struct net_shaper_binding *binding, > + const struct net_shaper_handle *handle, > + struct netlink_ext_ack *extack) > +{ > + struct iavf_adapter *adapter = netdev_priv(binding->netdev); > + int qid = handle->id; > + > + if (qid >= adapter->num_active_queues) { > + NL_SET_ERR_MSG_FMT(extack, "Invalid shaper handle, queued id %d > max %d", > + qid, adapter->num_active_queues); > + return -EINVAL; > + } > + return 0; > +}
This can go once we have the real_num validation in the core? Otherwise LGTM!